linux-kernel - Re: [PATCH v3 6/7] PCI: xilinx-nwl: Add phy support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <986ff09f-212c-4905-ab06-35f85e20e9cf@web.de>
Date: Fri, 24 May 2024 17:35:42 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Sean Anderson <sean.anderson@...ux.dev>,
 linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
 kernel-janitors@...r.kernel.org, Krzysztof Wilczyński
 <kw@...ux.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
 Michal Simek <michal.simek@....com>, Michal Simek <michal.simek@...inx.com>,
 Thippeswamy Havalige <thippeswamy.havalige@....com>
Subject: Re: [PATCH v3 6/7] PCI: xilinx-nwl: Add phy support

>> …
>>> +++ b/drivers/pci/controller/pcie-xilinx-nwl.c
>> …
>>> @@ -818,12 +876,15 @@ static int nwl_pcie_probe(struct platform_device *pdev)
>>>  		err = nwl_pcie_enable_msi(pcie);
>>>  		if (err < 0) {
>>>  			dev_err(dev, "failed to enable MSI support: %d\n", err);
>>> -			goto err_clk;
>>> +			goto err_phy;
>>>  		}
>>>  	}
>>>
>>>  	err = pci_host_probe(bridge);
>>>
>>> +err_phy:
>>> +	if (err)
>>> +		nwl_pcie_phy_disable(pcie);
>>>  err_clk:
>>>  	if (err)
>>>  		clk_disable_unprepare(pcie->clk);
>>
>> I got the impression that some source code adjustments should be performed
>> in another separate update step for this function implementation.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n81
>>
>> You propose to extend the exception handling here.
>> Does such information indicate a need for another tag “Fixes”?
>
> Huh? I am only disabling what I enabled...

* Was a resource deactivation accidentally missing in a previous release
  of this software component?

* Can repeated checks be avoided a bit more by a design approach which we tried
  to clarify for the update step “[PATCH v3 5/7] PCI: xilinx-nwl: Clean up clock
  on probe failure/removal”?
  https://lore.kernel.org/lkml/bb9e239f-902b-4f52-a5e9-98c29b360418@linux.dev/


Regards,
Markus