linux-kernel - Re: RISC-V: add Star64 board devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240525-shirt-scratch-6708b2a4f63b@spud>
Date: Sat, 25 May 2024 13:25:45 +0100
From: Conor Dooley <conor@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Henry Bell <dmoo_dv@...tonmail.com>, linux-riscv@...ts.infradead.org,
	devicetree@...r.kernel.org, Albert Ou <aou@...s.berkeley.edu>,
	Conor Dooley <conor+dt@...nel.org>,
	Emil Renner Berthing <kernel@...il.dk>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Palmer Dabbelt <palmer@...belt.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Rob Herring <robh@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: RISC-V: add Star64 board devicetree

On Sat, May 25, 2024 at 02:11:05PM +0200, Markus Elfring wrote:
> >>> Would you like to add an imperative wording for an improved change description?
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94
> …
> >> I'm happy to change it, but was going off the format used in Conor's  Milkv Mars commit
> >> https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/commit/?id=04a228aadb84d894721b13197649ca741f3018bc
> >
> > Don't worry about Markus, most maintainers (myself included) ignore his
> > comments on patches. The commit message here is fine.
> 
> Would such a response mean also that you are occasionally ignoring requirements
> from a referenced Linux development guideline?

I do ignore it from time to time, yes. Being a stickler to the
guidelines wastes everybody's time (just like this discussion).
That said, the tense used in this patch is perfectly in-line with the
guideline you reference. "Add Star64 board devicetree" is in the
imperative and the commit message body contains additional information
about the board's configuration.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)