linux-kernel - Re: [PATCH v3 4/8] x86/amd_nb: Enhance SMN access error checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8610cb8f-ad3a-421a-8a85-4c498c8fd0bf@web.de>
Date: Sat, 25 May 2024 15:55:38 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Yazen Ghannam <yazen.ghannam@....com>, linux-edac@...r.kernel.org,
 linux-hwmon@...r.kernel.org, kernel-janitors@...r.kernel.org,
 x86@...nel.org, Günter Röck <linux@...ck-us.net>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH v3 4/8] x86/amd_nb: Enhance SMN access error checking

> Furthermore, require error checking for callers of amd_smn_read() and
> amd_smn_write(). This is needed because many error conditions cannot
> be checked by these functions.

Does such information qualify for the tag “Fixes”?


>                                                 … And remove a warning
> that will not be trigger in many cases.

                   triggered?

I suggest to perform this source code cleanup in a separate update step.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n81

Regards,
Markus