linux-kernel - Re: [PATCH v4 04/10] iio: imu: adis_buffer: Add buffer setup API with buffer attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240526133803.133cd866@jic23-huawei>
Date: Sun, 26 May 2024 13:38:03 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Ramona Gradinariu <ramona.bolboaca13@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, conor+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, robh@...nel.org, nuno.sa@...log.com
Subject: Re: [PATCH v4 04/10] iio: imu: adis_buffer: Add buffer setup API
 with buffer attributes


>  /**
> - * devm_adis_setup_buffer_and_trigger() - Sets up buffer and trigger for
> - *					  the managed adis device
> + * devm_adis_setup_buffer_and_trigger_with_attrs() - Sets up buffer and trigger
> + * for the managed adis device with buffer attributes.
>   * @adis: The adis device
>   * @indio_dev: The IIO device
> - * @trigger_handler: Optional trigger handler, may be NULL.
> + * @trigger_handler: Trigger handler: should handle the buffer readings.
> + * @ops: Optional buffer setup functions, may be NULL.
> + * @buffer_attrs: Extra buffer attributes.
>   *
>   * Returns 0 on success, a negative error code otherwise.
>   *
> - * This function sets up the buffer and trigger for a adis devices.  If
> - * 'trigger_handler' is NULL the default trigger handler will be used. The
> - * default trigger handler will simply read the registers assigned to the
> - * currently active channels.
> + * This function sets up the buffer (with buffer setup functions and extra
> + * buffer attributes) and trigger for a adis devices with buffer attributes.
>   */
>  int
> -devm_adis_setup_buffer_and_trigger(struct adis *adis, struct iio_dev *indio_dev,
> -				   irq_handler_t trigger_handler)
> +devm_adis_setup_buffer_and_trigger_with_attrs(struct adis *adis, struct iio_dev *indio_dev,

Trivial, but as you are doing a v5 anyway for Nuno's feedback
please add a line break after adis,

Whilst for the following lines readability would be hurt by breaking the lines
that isn't true for this first line.

> +					      irq_handler_t trigger_handler,
> +					      const struct iio_buffer_setup_ops *ops,
> +					      const struct iio_dev_attr **buffer_attrs)
>  {