linux-kernel - Re: [PATCH v4 08/10] iio: imu: adis16475: Re-define ADIS16475

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240526134344.6675ab5c@jic23-huawei>
Date: Sun, 26 May 2024 13:43:44 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@...il.com>,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, conor+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, robh@...nel.org, nuno.sa@...log.com
Subject: Re: [PATCH v4 08/10] iio: imu: adis16475: Re-define ADIS16475_DATA

On Fri, 24 May 2024 12:47:38 +0200
Nuno Sá <noname.nuno@...il.com> wrote:

> On Fri, 2024-05-24 at 12:00 +0300, Ramona Gradinariu wrote:
> > Re-define ADIS16475_DATA such that it takes _has_fifo as parameter.
> > 
> > Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@...il.com>
> > ---  
> 
> I may be missing something but do we actually need to patches redefining the macro?
> If I'm not missing nothing the first patch is only relevant for the new ADIS devices
> which are added in patch 10. So maybe squash both patches changing the macro.
> 
> - Nuno Sá
> 
If that's not possible for some reason, give them both slightly more detailed
patch titles. It's confusing to have them identical!
 
I'd prefer them squashed as Nuno suggested.