linux-kernel - Re: [PATCH v2] wifi: brcm80211: use sizeof(*pointer) instead of sizeof(type)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 27 May 2024 20:08:51 +0200
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Erick Archer <erick.archer@...look.com>, Kalle Valo <kvalo@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Ulf Hansson <ulf.hansson@...aro.org>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Yajun Deng <yajun.deng@...ux.dev>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Alan Stern <stern@...land.harvard.edu>, Dmitry Antipov
 <dmantipov@...dex.ru>, Johannes Berg <johannes.berg@...el.com>,
 Arnd Bergmann <arnd@...db.de>, Jonas Gorski <jonas.gorski@...il.com>,
 Artem Chernyshev <artem.chernyshev@...-soft.ru>,
 Kees Cook <keescook@...omium.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Justin Stitt <justinstitt@...gle.com>
Cc: linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
 brcm80211-dev-list.pdl@...adcom.com, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] wifi: brcm80211: use sizeof(*pointer) instead of
 sizeof(type)

On 5/27/2024 7:34 PM, Erick Archer wrote:
> It is preferred to use sizeof(*pointer) instead of sizeof(type)
> due to the type of the variable can change and one needs not
> change the former (unlike the latter). This patch has no effect
> on runtime behavior.
> 
> At the same time remove some redundant NULL initializations.

Thanks. The ACK still stands ;-)

> Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Erick Archer <erick.archer@...look.com>
> ---
> Changes in v2:
> - Remove some redundant NULL initializations (Arend van Spriel).
> - Refactor a bit the logic of "phy_lcn.c" (Arend van Spriel).
> - Add the "Acked-by:" tag.
> 
> Previous versions:
> v1 -> https://lore.kernel.org/linux-hardening/AS8PR02MB7237C3696881F79EAEE8D02E8BF72@AS8PR02MB7237.eurprd02.prod.outlook.com/
> ---
>   .../broadcom/brcm80211/brcmfmac/bcmsdh.c      |  4 ++--
>   .../broadcom/brcm80211/brcmfmac/btcoex.c      |  4 ++--
>   .../broadcom/brcm80211/brcmfmac/sdio.c        |  2 +-
>   .../broadcom/brcm80211/brcmfmac/usb.c         |  6 ++---
>   .../broadcom/brcm80211/brcmsmac/aiutils.c     |  2 +-
>   .../broadcom/brcm80211/brcmsmac/ampdu.c       |  2 +-
>   .../broadcom/brcm80211/brcmsmac/antsel.c      |  2 +-
>   .../broadcom/brcm80211/brcmsmac/channel.c     |  2 +-
>   .../broadcom/brcm80211/brcmsmac/dma.c         |  2 +-
>   .../broadcom/brcm80211/brcmsmac/mac80211_if.c |  2 +-
>   .../broadcom/brcm80211/brcmsmac/main.c        | 23 +++++++++----------
>   .../broadcom/brcm80211/brcmsmac/phy/phy_cmn.c |  4 ++--
>   .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c |  6 ++---
>   .../broadcom/brcm80211/brcmsmac/phy_shim.c    |  4 ++--
>   14 files changed, 32 insertions(+), 33 deletions(-)

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)