linux-kernel - Re: [PATCH] ipvs: Avoid unnecessary calls to skb_is_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16cacbcd-2f4c-1dc1-ecf7-8c081c84c6aa@ssi.bg>
Date: Mon, 27 May 2024 20:59:37 +0300 (EEST)
From: Julian Anastasov <ja@....bg>
To: Ismael Luceno <iluceno@...e.de>
cc: linux-kernel@...r.kernel.org, Pablo Neira Ayuso <pablo@...filter.org>,
        Michal Kubeček <mkubecek@...e.com>,
        Simon Horman <horms@...ge.net.au>, lvs-devel@...r.kernel.org,
        netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        coreteam@...filter.org
Subject: Re: [PATCH] ipvs: Avoid unnecessary calls to skb_is_gso_sctp


	Hello,

On Thu, 23 May 2024, Ismael Luceno wrote:

> In the context of the SCTP SNAT/DNAT handler, these calls can only
> return true.
> 
> Ref: e10d3ba4d434 ("ipvs: Fix checksumming on GSO of SCTP packets")

	checkpatch.pl prefers to see the "commit" word:

Ref: commit e10d3ba4d434 ("ipvs: Fix checksumming on GSO of SCTP packets")

> Signed-off-by: Ismael Luceno <iluceno@...e.de>

	Looks good to me for nf-next, thanks!

Acked-by: Julian Anastasov <ja@....bg>

> CC: Pablo Neira Ayuso <pablo@...filter.org>
> CC: Michal Kubeček <mkubecek@...e.com>
> CC: Simon Horman <horms@...ge.net.au>
> CC: Julian Anastasov <ja@....bg>
> CC: lvs-devel@...r.kernel.org
> CC: netfilter-devel@...r.kernel.org
> CC: netdev@...r.kernel.org
> CC: coreteam@...filter.org
> ---
>  net/netfilter/ipvs/ip_vs_proto_sctp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_proto_sctp.c b/net/netfilter/ipvs/ip_vs_proto_sctp.c
> index 1e689c714127..83e452916403 100644
> --- a/net/netfilter/ipvs/ip_vs_proto_sctp.c
> +++ b/net/netfilter/ipvs/ip_vs_proto_sctp.c
> @@ -126,7 +126,7 @@ sctp_snat_handler(struct sk_buff *skb, struct ip_vs_protocol *pp,
>  	if (sctph->source != cp->vport || payload_csum ||
>  	    skb->ip_summed == CHECKSUM_PARTIAL) {
>  		sctph->source = cp->vport;
> -		if (!skb_is_gso(skb) || !skb_is_gso_sctp(skb))
> +		if (!skb_is_gso(skb))
>  			sctp_nat_csum(skb, sctph, sctphoff);
>  	} else {
>  		skb->ip_summed = CHECKSUM_UNNECESSARY;
> @@ -175,7 +175,7 @@ sctp_dnat_handler(struct sk_buff *skb, struct ip_vs_protocol *pp,
>  	    (skb->ip_summed == CHECKSUM_PARTIAL &&
>  	     !(skb_dst(skb)->dev->features & NETIF_F_SCTP_CRC))) {
>  		sctph->dest = cp->dport;
> -		if (!skb_is_gso(skb) || !skb_is_gso_sctp(skb))
> +		if (!skb_is_gso(skb))
>  			sctp_nat_csum(skb, sctph, sctphoff);
>  	} else if (skb->ip_summed != CHECKSUM_PARTIAL) {
>  		skb->ip_summed = CHECKSUM_UNNECESSARY;
> -- 
> 2.44.0

Regards

--
Julian Anastasov <ja@....bg>