linux-kernel - Re: [PATCH] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <771db1ec-115f-4b96-916f-3975ca302f55@kernel.org>
Date: Mon, 27 May 2024 20:47:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shresth Prasad <shresthprasad7@...il.com>, wim@...ux-watchdog.org,
 linux@...ck-us.net, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
 javier.carrasco.cruz@...il.com
Subject: Re: [PATCH] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

On 27/05/2024 08:21, Shresth Prasad wrote:
> Convert txt bindings of ImgTec's PDC watchdog timer to dtschema to allow
> for validation.
> 
> Signed-off-by: Shresth Prasad <shresthprasad7@...il.com>
> ---
> The binding has been checked and tested against `img/pistachio_marduk.dts`
> with no errors or warnings.
> ---


Thank you for your patch. There is something to discuss/improve.


> +
> +maintainers:
> +  - Shresth Prasad <shresthprasad7@...il.com>
> +
> +

Just one blank line.

> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - img,pdc-wdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 2

Instead of maxItems please list items with description so the items will
be described.

> +
> +  clock-names:
> +    items:
> +      - const: wdt
> +      - const: sys
> +
> +  interrupts:
> +    description:
> +      Should contain WDT interrupt

Drop description, redundant.

> +    maxItems: 1
> +
> +  assigned-clocks:
> +    maxItems: 2

Drop property

> +
> +  assigned-clock-rates:
> +    maxItems: 2

Drop property

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +
Best regards,
Krzysztof