linux-kernel - Re: [PATCH] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE8VWiLbxeKKtW051nPxagRq6xqZ+J1SHrG=AhOx+NALv7-GGA@mail.gmail.com>
Date: Tue, 28 May 2024 01:25:03 +0530
From: Shresth Prasad <shresthprasad7@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: wim@...ux-watchdog.org, linux@...ck-us.net, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-watchdog@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	skhan@...uxfoundation.org, javier.carrasco.cruz@...il.com
Subject: Re: [PATCH] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

On Tue, May 28, 2024 at 12:17 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 27/05/2024 08:21, Shresth Prasad wrote:
> > Convert txt bindings of ImgTec's PDC watchdog timer to dtschema to allow
> > for validation.
> >
> > Signed-off-by: Shresth Prasad <shresthprasad7@...il.com>
> > ---
> > The binding has been checked and tested against `img/pistachio_marduk.dts`
> > with no errors or warnings.
> > ---
>
>
> Thank you for your patch. There is something to discuss/improve.
>
>
> > +
> > +maintainers:
> > +  - Shresth Prasad <shresthprasad7@...il.com>
> > +
> > +
>
> Just one blank line.
>
> > +allOf:
> > +  - $ref: watchdog.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - img,pdc-wdt
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 2
>
> Instead of maxItems please list items with description so the items will
> be described.
>
> > +
> > +  clock-names:
> > +    items:
> > +      - const: wdt
> > +      - const: sys
> > +
> > +  interrupts:
> > +    description:
> > +      Should contain WDT interrupt
>
> Drop description, redundant.
>
> > +    maxItems: 1
> > +
> > +  assigned-clocks:
> > +    maxItems: 2
>
> Drop property
>
> > +
> > +  assigned-clock-rates:
> > +    maxItems: 2
>
> Drop property
>
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +  - interrupts
> > +
> Best regards,
> Krzysztof
>

Hi,

Thank you for the feedback.
I'll address these and resend the patch.

Regards,
Shresth