linux-kernel - Re: [PATCH] mm, slab: don't wrap internal functions with alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d63a0457-6333-4bd0-b1b7-b868ed753894@suse.cz>
Date: Mon, 27 May 2024 09:15:25 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Kees Cook <keescook@...omium.org>
Cc: Christoph Lameter <cl@...ux.com>, David Rientjes <rientjes@...gle.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Roman Gushchin <roman.gushchin@...ux.dev>,
 Hyeonggon Yoo <42.hyeyoo@...il.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Kent Overstreet <kent.overstreet@...ux.dev>,
 Suren Baghdasaryan <surenb@...gle.com>
Subject: Re: [PATCH] mm, slab: don't wrap internal functions with
 alloc_hooks()

On 5/25/24 1:26 AM, Kees Cook wrote:
> On Wed, May 22, 2024 at 11:50:37AM +0200, Vlastimil Babka wrote:
>> The functions __kmalloc_noprof(), kmalloc_large_noprof(),
>> kmalloc_trace_noprof() and their _node variants are all internal to the
>> implementations of kmalloc_noprof() and kmalloc_node_noprof() and are
>> only declared in the "public" slab.h and exported so that those
>> implementations can be static inline and distinguish the build-time
>> constant size variants. The only other users for some of the internal
>> functions are slub_kunit and fortify_kunit tests which make very
>> short-lived allocations.
> 
> If it's only internal, I'm happy to drop it from fortify_kunit.

Yeah, looks like you already have static and dynamic size parameter variants
of the tests so testing kmalloc() will call __kmalloc_noprof() in the
dynamic case (ditto _node variant) and is the best way to exercise that. So
So in v2 I will drop those from fortify_kunit instead of adjusting names.

> -Kees
>