linux-kernel - Re: [PATCH 3/3] staging: rtl8192e: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 27 May 2024 11:51:33 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Michael Straube <straube.linux@...il.com>
Cc: Nam Cao <namcao@...utronix.de>, gregkh@...uxfoundation.org,
	philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8192e: remove dead code

On Mon, May 27, 2024 at 10:34:41AM +0200, Michael Straube wrote:
> Am 27.05.24 um 09:39 schrieb Dan Carpenter:
> > This patch doesn't affect behavior at all, but to me the original
> > author wrote the do nothing case for readability, and I don't have a
> > problem with that.  In fact, I applaud the author for caring about
> > readability at all which is not a given in staging code.  :P
> 
> Then I think it's better to leave it as is. :)
> Should I send a v2 with this patched removed or will Greg just apply
> the first two patches and ignore this one?

Resend with Nam's reviewed-by tags.

regards,
dan carpenter