linux-kernel - Re: [PATCH] dt-bindings: hwmon: Add max6639

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c11900ec-dd03-43b7-916a-dc7315bb50b5@roeck-us.net>
Date: Tue, 28 May 2024 07:41:58 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Conor Dooley <conor@...nel.org>,
 Naresh Solanki <naresh.solanki@...ements.com>
Cc: Jean Delvare <jdelvare@...e.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-hwmon@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Add max6639

On 5/28/24 07:26, Conor Dooley wrote:
> On Tue, May 28, 2024 at 06:21:21PM +0530, Naresh Solanki wrote:
>> Add Devicetree binding documentation for Maxim MAX6639 temperature
>> monitor with PWM fan-speed controller.
> 
> Other than unneeded |s where your descriptions don't have any
> formatting, this patch looks fine. That said - where's your dts or your
> driver? A binding on its own is unusual.
> 

The driver is drivers/hwmon/max6639.c which needs other unrelated changes/
cleanups. Holding those up until the bindings are accepted would not make
sense, so my guess is that Naresh decided to pursue the other changes for now
and add devicetree support to the driver after the devicetree properties
have been approved. On the other side, adding devicetree support does depend
on the other changes, so trying to do that before the other changes are
complete would be difficult.

That is just my guess, though, and I am ok with it.

Thanks,
Guenter