linux-kernel - Re: [PATCH v2] selftests/net: suppress clang's "variable-sized type not at the end" warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <612a0c4f-dd79-400f-aa3b-a4f8bf7dba0c@nvidia.com>
Date: Tue, 28 May 2024 13:56:09 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Nathan Chancellor <nathan@...nel.org>
CC: Shuah Khan <shuah@...nel.org>, "David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>, Andreas Färber
	<afaerber@...e.de>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Matthieu Baerts <matttbe@...nel.org>, Mat Martineau <martineau@...nel.org>,
	Geliang Tang <geliang@...nel.org>, Pravin B Shelar <pshelar@....org>, "Willem
 de Bruijn" <willemdebruijn.kernel@...il.com>, Alexander Mikhalitsyn
	<alexander@...alicyn.com>, zhujun2 <zhujun2@...s.chinamobile.com>, "Petr
 Machata" <petrm@...dia.com>, Ido Schimmel <idosch@...dia.com>, Hangbin Liu
	<liuhangbin@...il.com>, Nikolay Aleksandrov <razor@...ckwall.org>, "Benjamin
 Poirier" <bpoirier@...dia.com>, Sebastian Andrzej Siewior
	<bigeasy@...utronix.de>, Dmitry Safonov <0x7f454c46@...il.com>,
	<netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-actions@...ts.infradead.org>, <mptcp@...ts.linux.dev>,
	<dev@...nvswitch.org>, Valentin Obst <kernel@...entinobst.de>,
	<linux-kselftest@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	<llvm@...ts.linux.dev>
Subject: Re: [PATCH v2] selftests/net: suppress clang's "variable-sized type
 not at the end" warning

On 5/28/24 1:39 PM, Nathan Chancellor wrote:
> On Mon, May 27, 2024 at 02:36:41PM -0700, John Hubbard wrote:
..
>> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
>> index bd01e4a0be2c..9a3b766c8781 100644
>> --- a/tools/testing/selftests/net/Makefile
>> +++ b/tools/testing/selftests/net/Makefile
>> @@ -6,6 +6,10 @@ CFLAGS += -I../../../../usr/include/ $(KHDR_INCLUDES)
>>   # Additional include paths needed by kselftest.h
>>   CFLAGS += -I../
>>   
>> +ifneq ($(LLVM),)
>> +    CFLAGS += -Wno-gnu-variable-sized-type-not-at-end
> 
> For what it's worth, the main kernel has -Wno-gnu because there is
> little point in warning about the use of GNU extensions when building
> with '-std=gnu...'. It may be worth doing this anywhere that uses a GNU
> standard in the selftests but I guess it depends on how noisy things
> are.

I think there might be one or two other cases like this that I haven't
gotten around to, so yes you are right, this probably should be moved
into lib.mk instead.

I'll do that in a v3.

> 
>> +endif
>> +
>>   TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh \
>>   	      rtnetlink.sh xfrm_policy.sh test_blackhole_dev.sh
>>   TEST_PROGS += fib_tests.sh fib-onlink-tests.sh pmtu.sh udpgso.sh ip_defrag.sh
>>
>> base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
>> -- 
>> 2.45.1
>>
>>

thanks,
-- 
John Hubbard
NVIDIA