linux-kernel - Re: [PATCH 5.15 00/23] 5.15.160-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 May 2024 20:55:38 +0000
From: Chuck Lever III <chuck.lever@...cle.com>
To: Jon Hunter <jonathanh@...dia.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Neil Brown
	<neilb@...e.de>,
        Chris Packham <Chris.Packham@...iedtelesis.co.nz>,
        linux-stable <stable@...r.kernel.org>,
        "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>,
        Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>,
        Linus Torvalds
	<torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "patches@...nelci.org" <patches@...nelci.org>,
        "lkft-triage@...ts.linaro.org"
	<lkft-triage@...ts.linaro.org>,
        "pavel@...x.de" <pavel@...x.de>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "sudipm.mukherjee@...il.com"
	<sudipm.mukherjee@...il.com>,
        "srw@...dewatkins.net" <srw@...dewatkins.net>,
        "rwarsow@....de" <rwarsow@....de>,
        "conor@...nel.org" <conor@...nel.org>,
        "allen.lkml@...il.com" <allen.lkml@...il.com>,
        "broonie@...nel.org"
	<broonie@...nel.org>,
        "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 5.15 00/23] 5.15.160-rc1 review



> On May 28, 2024, at 10:18 AM, Jon Hunter <jonathanh@...dia.com> wrote:
> 
> 
> On 28/05/2024 14:14, Chuck Lever III wrote:
>>> On May 28, 2024, at 5:04 AM, Jon Hunter <jonathanh@...dia.com> wrote:
>>> 
>>> 
>>> On 25/05/2024 15:20, Greg Kroah-Hartman wrote:
>>>> On Sat, May 25, 2024 at 12:13:28AM +0100, Jon Hunter wrote:
>>>>> Hi Greg,
>>>>> 
>>>>> On 23/05/2024 14:12, Greg Kroah-Hartman wrote:
>>>>>> This is the start of the stable review cycle for the 5.15.160 release.
>>>>>> There are 23 patches in this series, all will be posted as a response
>>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>>> let me know.
>>>>>> 
>>>>>> Responses should be made by Sat, 25 May 2024 13:03:15 +0000.
>>>>>> Anything received after that time might be too late.
>>>>>> 
>>>>>> The whole patch series can be found in one patch at:
>>>>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.160-rc1.gz
>>>>>> or in the git tree and branch at:
>>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>>>>>> and the diffstat can be found below.
>>>>>> 
>>>>>> thanks,
>>>>>> 
>>>>>> greg k-h
>>>>>> 
>>>>>> -------------
>>>>>> Pseudo-Shortlog of commits:
>>>>> 
>>>>> ...
>>>>> 
>>>>>> NeilBrown <neilb@...e.de>
>>>>>>      nfsd: don't allow nfsd threads to be signalled.
>>>>> 
>>>>> 
>>>>> I am seeing a suspend regression on a couple boards and bisect is pointing
>>>>> to the above commit. Reverting this commit does fix the issue.
>>>> Ugh, that fixes the report from others.  Can you cc: everyone on that
>>>> and figure out what is going on, as this keeps going back and forth...
>>> 
>>> 
>>> Adding Chuck, Neil and Chris from the bug report here [0].
>>> 
>>> With the above applied to v5.15.y, I am seeing suspend on 2 of our boards fail. These boards are using NFS and on entry to suspend I am now seeing ...
>>> 
>>> Freezing of tasks failed after 20.002 seconds (1 tasks refusing to
>>> freeze, wq_busy=0):
>>> 
>>> The boards appear to hang at that point. So may be something else missing?
>> Note that we don't have access to hardware like this, so
>> we haven't tested that patch (even the upstream version)
>> with suspend on that hardware.
> 
> 
> No problem, I would not expect you to have this particular hardware :-)
> 
>> So, it could be something missing, or it could be that
>> patch has a problem.
>> It would help us to know if you observe the same issue
>> with an upstream kernel, if that is possible.
> 
> 
> I don't observe this with either mainline, -next or any other stable branch. So that would suggest that something else is missing from linux-5.15.y.

That helps. It would be very helpful to have a reproducer I can
use to confirm we have a fix. I'm sure this will be a process
that involves a non-trivial number of iterations.


--
Chuck Lever