linux-kernel - Re: [PATCH v2] statx: stx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <24829B5A-5F68-4B3A-AD4E-1AD9EFDE1D0E@dilger.ca>
Date: Tue, 28 May 2024 16:11:28 -0600
From: Andreas Dilger <adilger@...ger.ca>
To: John Garry <john.g.garry@...cle.com>
Cc: Eric Biggers <ebiggers@...nel.org>,
 Kent Overstreet <kent.overstreet@...ux.dev>,
 linux-fsdevel <linux-fsdevel@...r.kernel.org>,
 linux-bcachefs@...r.kernel.org,
 linux-btrfs <linux-btrfs@...r.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Josef Bacik <josef@...icpanda.com>,
 Miklos Szeredi <mszeredi@...hat.com>,
 Christian Brauner <brauner@...nel.org>,
 David Howells <dhowells@...hat.com>
Subject: Re: [PATCH v2] statx: stx_subvol


> On May 28, 2024, at 6:46 AM, John Garry <john.g.garry@...cle.com> wrote:
> 
> On 12/03/2024 02:13, Eric Biggers wrote:
>> On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote:
>>>  	__u32	stx_dio_mem_align;	/* Memory buffer alignment for direct I/O */
>>>  	__u32	stx_dio_offset_align;	/* File offset alignment for direct I/O */
>>> +	__u64	stx_subvol;	/* Subvolume identifier */
>>>  	/* 0xa0 */
>>> -	__u64	__spare3[12];	/* Spare space for future expansion */
>>> +	__u64	__spare3[11];	/* Spare space for future expansion */
>>>  	/* 0x100 */
>> The /* 0xa0 */ comment needs to be updated (or deleted).
> 
> I would tend to agree. Was this intentionally not updated (or deleted)?

More correct would be to add the new stx_subvol field after the "0xa0"
comment so that it is clear at what offset in the struct this field is.

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)