[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e3aa72af-c824-4b71-a99d-c0b9294bfd8a@kernel.org>
Date: Tue, 28 May 2024 08:53:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Esben Haabendal <esben@...nix.com>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>,
Pratyush Yadav <pratyush@...nel.org>, Michael Walle <mwalle@...nel.org>,
linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] memory: fsl_ifc: Make FSL_IFC config visible and
selectable
On 27/05/2024 09:47, Esben Haabendal wrote:
>
> Ok, I seem to still be confused as to what you want from me. If you are
> saying that the kernel is not supposed to care about out-of-tree DTS
> (and thereby any bootloader provided DTB), I would like to bring your
> attention to arch/arm/boot/dts/nxp/ls/ls1021a-twr.dts in upstream:
>
> &ifc {
> #address-cells = <2>;
> #size-cells = <1>;
> /* NOR Flash on board */
> ranges = <0x0 0x0 0x0 0x60000000 0x08000000>;
> status = "okay";
>
> nor@0,0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> };
>
I don't understand why it took so many emails to answer that (my first)
question... Sounds good, however you did not update the existing select.
Drivers are not supposed to select user-visible symbols (leads to
issues), so you need to change it to depends and update defconfigs.
Best regards,
Krzysztof
Powered by blists - more mailing lists