linux-kernel - Re: [PATCH] clk: sifive: Do not register clkdevs for PRCI clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZlWTJvvTSm2hH2ls@shell.armlinux.org.uk>
Date: Tue, 28 May 2024 09:17:42 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Samuel Holland <samuel.holland@...ive.com>
Cc: Stephen Boyd <sboyd@...nel.org>, Guenter Roeck <linux@...ck-us.net>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Dinh Nguyen <dinguyen@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Michael Turquette <mturquette@...libre.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Rob Herring <robh@...nel.org>, Yang Li <yang.lee@...ux.alibaba.com>,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] clk: sifive: Do not register clkdevs for PRCI clocks

On Mon, May 27, 2024 at 05:14:12PM -0700, Samuel Holland wrote:
> These clkdevs were unnecessary, because systems using this driver always
> look up clocks using the devicetree. And as Russell King points out[1],
> since the provided device name was truncated, lookups via clkdev would
> never match.
> 
> Recently, commit 8d532528ff6a ("clkdev: report over-sized strings when
> creating clkdev entries") caused clkdev registration to fail due to the
> truncation, and this now prevents the driver from probing. Fix the
> driver by removing the clkdev registration.
> 
> Link: https://lore.kernel.org/linux-clk/ZkfYqj+OcAxd9O2t@shell.armlinux.org.uk/ [1]
> Fixes: 30b8e27e3b58 ("clk: sifive: add a driver for the SiFive FU540 PRCI IP block")
> Fixes: 8d532528ff6a ("clkdev: report over-sized strings when creating clkdev entries")

This doesn't really fix this commit, since if someone else is doing the
same thing, then they too may also fail to boot, so I'd suggest that
this Fixes tag is removed.

See https://lore.kernel.org/r/E1sBrzn-00E8GK-Ue@rmk-PC.armlinux.org.uk

for a fix that solves the issue introduced by that commit.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!