linux-kernel - Re: [PATCH] clk: sifive: Do not register clkdevs for PRCI clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 29 May 2024 13:53:29 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Samuel Holland <samuel.holland@...ive.com>
Cc: Samuel Holland <samuel.holland@...ive.com>, Guenter Roeck <linux@...ck-us.net>, Russell King <linux@...linux.org.uk>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Dinh Nguyen <dinguyen@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Michael Turquette <mturquette@...libre.com>, Paul Walmsley <paul.walmsley@...ive.com>, Rob Herring <robh@...nel.org>, Russell King (Oracle) <rmk+kernel@...linux.org.uk>, Yang Li <yang.lee@...ux.alibaba.com>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] clk: sifive: Do not register clkdevs for PRCI clocks

Quoting Samuel Holland (2024-05-27 17:14:12)
> These clkdevs were unnecessary, because systems using this driver always
> look up clocks using the devicetree. And as Russell King points out[1],
> since the provided device name was truncated, lookups via clkdev would
> never match.
> 
> Recently, commit 8d532528ff6a ("clkdev: report over-sized strings when
> creating clkdev entries") caused clkdev registration to fail due to the
> truncation, and this now prevents the driver from probing. Fix the
> driver by removing the clkdev registration.
> 
> Link: https://lore.kernel.org/linux-clk/ZkfYqj+OcAxd9O2t@shell.armlinux.org.uk/ [1]
> Fixes: 30b8e27e3b58 ("clk: sifive: add a driver for the SiFive FU540 PRCI IP block")
> Fixes: 8d532528ff6a ("clkdev: report over-sized strings when creating clkdev entries")
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Closes: https://lore.kernel.org/linux-clk/7eda7621-0dde-4153-89e4-172e4c095d01@roeck-us.net/
> Suggested-by: Russell King <linux@...linux.org.uk>
> Signed-off-by: Samuel Holland <samuel.holland@...ive.com>
> ---

Applied to clk-fixes