linux-kernel - Re: [PATCH v2 1/2] xhci: Apply reset resume quirk to Etron EJ188 xHCI host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHN5xi00mi7T2M9Bj+r9b1gpw2YX5bfXbUzj5ocTSFLBQjpfuw@mail.gmail.com>
Date: Tue, 28 May 2024 17:53:28 +0800
From: 蔣光益 <ki.chiang65@...il.com>
To: Sergei Shtylyov <sergei.shtylyov@...il.com>
Cc: mathias.nyman@...el.com, gregkh@...uxfoundation.org, 
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] xhci: Apply reset resume quirk to Etron EJ188 xHCI host

Hi Sergey,

Sergei Shtylyov <sergei.shtylyov@...il.com> 於 2024年5月28日 週二 下午4:36寫道：
>
> On 5/28/24 6:31 AM, Kuangyi Chiang wrote:
>
> > As described in commit c877b3b2ad5c ("xhci: Add reset on resume quirk for
> > asrock p67 host"), EJ188 have the same issue as EJ168, where completely
> > dies on resume. So apply XHCI_RESET_ON_RESUME quirk to EJ188 as well.
> >
> > Cc: <stable@...r.kernel.org>
> > Signed-off-by: Kuangyi Chiang <ki.chiang65@...il.com>
> > ---
> > Changes in v2:
> > - Porting to latest release
> >
> >  drivers/usb/host/xhci-pci.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index c040d816e626..b47d57d80b96 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> [...]
> > @@ -395,6 +396,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> >               xhci->quirks |= XHCI_RESET_ON_RESUME;
> >               xhci->quirks |= XHCI_BROKEN_STREAMS;
> >       }
> > +     if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> > +                     pdev->device == PCI_DEVICE_ID_EJ188) {
> > +             xhci->quirks |= XHCI_RESET_ON_RESUME;
> > +     }
>
>    You don't need {} around a single statement, according to CodingStyle.
>
> [...]
>
> MBR, Sergey

Got it, I'll modify it and resend patches.

Thanks,
Kuangyi Chiang