[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VeOX3NqPxFWduRAXGhw8zDA1a4E1jk6L3DzvfjKX-KjVA@mail.gmail.com>
Date: Tue, 28 May 2024 12:52:28 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Guanbing Huang <albanhuang@...look.com>,
Guanbing Huang <albanhuang@...cent.com>, Woody Suwalski <terraluna977@...il.com>
Subject: Re: [PATCH v1 1/1] PNP: Export pnp_bus_type for modules
On Tue, May 28, 2024 at 12:42 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
> On Mon, May 27, 2024 at 10:24 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > Since we have dev_is_pnp() macro that utilises the address of pnp_bus_type
> > variable, the users, which can be compiled as modules, will be failed to
> > build. Export the variable to the modules to prevent build breakage.
..
> > +EXPORT_SYMBOL(pnp_bus_type);
>
> Why not EXPORT_SYMBOL_GPL()?
To be consistent with the rest, but in any case Christoph suggested
something else, where _GPL is assumed to be.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists