linux-kernel - Re: [PATCH v1 1/1] PNP: Export pnp_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hQ4vaj88HVECyNon2Kyy=v6q0Bi+=+3TeA6LNE1Aq6-A@mail.gmail.com>
Date: Tue, 28 May 2024 11:58:37 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Guanbing Huang <albanhuang@...look.com>, 
	Guanbing Huang <albanhuang@...cent.com>, Woody Suwalski <terraluna977@...il.com>
Subject: Re: [PATCH v1 1/1] PNP: Export pnp_bus_type for modules

On Tue, May 28, 2024 at 11:53 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Tue, May 28, 2024 at 12:42 PM Rafael J. Wysocki <rafael@...nelorg> wrote:
> > On Mon, May 27, 2024 at 10:24 PM Andy Shevchenko
> > <andy.shevchenko@...il.com> wrote:
> > >
> > > Since we have dev_is_pnp() macro that utilises the address of pnp_bus_type
> > > variable, the users, which can be compiled as modules, will be failed to
> > > build. Export the variable to the modules to prevent build breakage.
>
> ...
>
> > > +EXPORT_SYMBOL(pnp_bus_type);
> >
> > Why not EXPORT_SYMBOL_GPL()?
>
> To be consistent with the rest, but in any case Christoph suggested
> something else, where _GPL is assumed to be.

Yes, that's even better.