linux-kernel - Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240528110511.00006fe5@Huawei.com>
Date: Tue, 28 May 2024 11:05:11 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Arthur Becker <arthur.becker@...tec.com>
CC: Krzysztof Kozlowski <krzk@...nel.org>, Jonathan Cameron
	<jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add
 VEML6040 RGBW-LS bindings

On Tue, 28 May 2024 07:23:03 +0000
Arthur Becker <arthur.becker@...tec.com> wrote:

> Thanks for the Review!
> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> I'll modify that the next time I make adjustments to the driver.

It's absolutely fine to have shared bindings even if the
drivers (because of different register interface etc) are completely
separate.  It's a good way to keep bindings aligned between
similar devices.

Jonathan

> 
> Kind regards,
> Arthur
> 
> ________________________________________
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 27 May 2024 18:31
> To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> Cc: linux-kernel@...r.kernel.org; linux-iio@...r.kernel.org; devicetree@...r.kernel.org
> Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> 
> On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > From: Arthur Becker <arthur.becker@...tec.com>
> >
> > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > driver
> >
> > Signed-off-by: Arthur Becker <arthur.becker@...tec.com>
> > ---
> > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > along with v2 of the driver but not in a set)  
> 
> It's basically the same as veml6075, so should be put there...
> 
> Eh,
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
> 
>