linux-kernel - Re: [PATCH v4 2/4] RAS/AMD/ATL: Expand helpers for adding and removing base and hole

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240528100714.GEZlWs0qL8tmCb9Mw3@fat_crate.local>
Date: Tue, 28 May 2024 12:07:14 +0200
From: Borislav Petkov <bp@...en8.de>
To: John Allen <john.allen@....com>
Cc: linux-edac@...r.kernel.org, tony.luck@...el.com, yazen.ghannam@....com,
	linux-kernel@...r.kernel.org, avadhut.naik@....com,
	muralidhara.mk@....com
Subject: Re: [PATCH v4 2/4] RAS/AMD/ATL: Expand helpers for adding and
 removing base and hole

On Mon, May 06, 2024 at 03:46:03PM +0000, John Allen wrote:
> +u64 add_base_and_hole(struct addr_ctx *ctx, u64 addr)
>  {
> -	ctx->ret_addr += get_base_addr(ctx);
> -
> -	if (add_legacy_hole(ctx))
> -		return -EINVAL;
> +	addr += get_base_addr(ctx);
> +	return add_legacy_hole(ctx, addr);

	return add_legacy_hole(ctx, addr + get_base_addr(ctx));

That's still readable. :)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette