[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87le3ukqnj.fsf@geanix.com>
Date: Tue, 28 May 2024 15:33:04 +0200
From: Esben Haabendal <esben@...nix.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, Pratyush Yadav
<pratyush@...nel.org>, Michael Walle <mwalle@...nel.org>, Miquel Raynal
<miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>, Michael Ellerman
<mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Christophe
Leroy <christophe.leroy@...roup.eu>, "Aneesh Kumar K.V"
<aneesh.kumar@...nel.org>, "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 2/2] powerpc/configs: Update defconfig with now
user-visible CONFIG_FSL_IFC
Krzysztof Kozlowski <krzk@...nel.org> writes:
> On 28/05/2024 14:28, Esben Haabendal wrote:
>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
>> selected in config snippets.
>>
>> Signed-off-by: Esben Haabendal <esben@...nix.com>
>> ---
>> arch/powerpc/configs/85xx-hw.config | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx-hw.config
>> index 524db76f47b7..8aff83217397 100644
>> --- a/arch/powerpc/configs/85xx-hw.config
>> +++ b/arch/powerpc/configs/85xx-hw.config
>> @@ -24,6 +24,7 @@ CONFIG_FS_ENET=y
>> CONFIG_FSL_CORENET_CF=y
>> CONFIG_FSL_DMA=y
>> CONFIG_FSL_HV_MANAGER=y
>> +CONFIG_FSL_IFC=y
>
> Does not look like placed according to config order.
Correct.
> This is not alphabetically sorted, but as Kconfig creates it (make
> savedefconfig).
Are you sure about this?
It looks very much alphabetically sorted, with only two "errors"
$ diff -u 85xx-hw.config 85xx-hw.config.sorted
--- 85xx-hw.config 2024-05-28 15:05:44.665354428 +0200
+++ 85xx-hw.config.sorted 2024-05-28 15:05:56.102019081 +0200
@@ -15,8 +15,8 @@
CONFIG_DMADEVICES=y
CONFIG_E1000E=y
CONFIG_E1000=y
-CONFIG_EDAC=y
CONFIG_EDAC_MPC85XX=y
+CONFIG_EDAC=y
CONFIG_EEPROM_AT24=y
CONFIG_EEPROM_LEGACY=y
CONFIG_FB_FSL_DIU=y
@@ -71,10 +71,10 @@
CONFIG_MTD_CMDLINE_PARTS=y
CONFIG_MTD_NAND_FSL_ELBC=y
CONFIG_MTD_NAND_FSL_IFC=y
-CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_PHYSMAP_OF=y
CONFIG_MTD_PHYSMAP=y
CONFIG_MTD_PLATRAM=y
+CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_SPI_NOR=y
CONFIG_NETDEVICES=y
CONFIG_NVRAM=y
I don't think that this file has ever been Kconfig sorted since it was
created back in ancient times.
And as it is merged with other config snippets using merge_into_defconfig
function. I have no idea how to use savedefconfig to maintain such a snippet.
It would require doing the reverse of the merge_into_defconfig.
>> CONFIG_FSL_PQ_MDIO=y
>> CONFIG_FSL_RIO=y
>
> You also missed to update second defconfig - arm64.
Argh. I thought I checked, and it did not need any changes. But it needs
to have CONFIG_FSL_IFC=y added.
I will add that for v3.
/Esben
Powered by blists - more mailing lists