linux-kernel - Re: [PATCH] platform/x86: int3472: make common part a separate module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <436667b5-308a-4a0b-b66e-230667ce0cc3@app.fastmail.com>
Date: Wed, 29 May 2024 16:13:57 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Andy Shevchenko" <andy.shevchenko@...il.com>,
 "Arnd Bergmann" <arnd@...nel.org>
Cc: "Daniel Scally" <djrscally@...il.com>,
 "Hans de Goede" <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: int3472: make common part a separate module

On Wed, May 29, 2024, at 15:41, Andy Shevchenko wrote:
> On Wed, May 29, 2024 at 12:50 PM Arnd Bergmann <arnd@...nel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@...db.de>
>>
>> Linking an object file into multiple modules is not supported
>> and causes a W=1 warning:
>>
>> scripts/Makefile.build:236: drivers/platform/x86/intel/int3472/Makefile: common.o is added to multiple modules: intel_skl_int3472_discrete intel_skl_int3472_tps68470
>>
>> Split out the common part here into a separate module to make it
>> more reliable.
>
> ...
>
>>  obj-$(CONFIG_INTEL_SKL_INT3472)                += intel_skl_int3472_discrete.o \
>> -                                          intel_skl_int3472_tps68470o
>
>> +                                          intel_skl_int3472_tps68470o \
>> +                                          intel_skl_int3472_common.o
>
> A nit: Can this be put above instead?

I've changed it like this now, is that what you meant?


obj-$(CONFIG_INTEL_SKL_INT3472)         += intel_skl_int3472_common.o \
                                           intel_skl_int3472_discrete.o \
                                           intel_skl_int3472_tps68470.o \

intel_skl_int3472_common-y      += common.o
intel_skl_int3472_discrete-y    := discrete.o clk_and_regulator.o led.o
intel_skl_int3472_tps68470-y    := tps68470.o tps68470_board_data.o

> ...
>
>> +EXPORT_SYMBOL_GPL(skl_int3472_get_sensor_adev_and_name);
>
> Are these namespaced?

No, is there any advantage to making them namespaced?

It's only a few symbols and they have proper prefixes.

     Arnd