lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c0bcb7b5-3155-445f-94ff-4020fe05109d@moroto.mountain>
Date: Wed, 29 May 2024 19:28:02 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org,
	linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: adt7316: remove unused struct
 'adt7316_limit_regs'

On Wed, May 29, 2024 at 04:01:24PM +0000, Dr. David Alan Gilbert wrote:
> * Dan Carpenter (dan.carpenter@...aro.org) wrote:
> > On Wed, May 29, 2024 at 12:30:08AM +0100, linux@...blig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > > 
> > > 'adt7316_limit_regs' has never been used since the original
> > > commit 35f6b6b86ede ("staging: iio: new ADT7316/7/8 and ADT7516/7/9
> > > driver").
> > > 
> > > The comment above it is a copy-and-paste from a different struct.
> > > 
> > > Remove both the struct and the comment.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > > ---
> > >  drivers/staging/iio/addac/adt7316.c | 8 --------
> > >  1 file changed, 8 deletions(-)
> > > 
> > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> > > index 79467f056a05..23d036d2802c 100644
> > > --- a/drivers/staging/iio/addac/adt7316.c
> > > +++ b/drivers/staging/iio/addac/adt7316.c
> > > @@ -209,14 +209,6 @@ struct adt7316_chip_info {
> > >  #define ADT7316_TEMP_AIN_INT_MASK	\
> > >  	(ADT7316_TEMP_INT_MASK)
> > >  
> > > -/*
> > > - * struct adt7316_chip_info - chip specific information
> > > - */
> > > -
> > > -struct adt7316_limit_regs {
> > > -	u16	data_high;
> > > -	u16	data_low;
> > > -};
> > >  
> > 
> > Could you delete the blank line as well?  Otherwise we have two blank
> > lines in a row and checkpatch will complain.
> 
> Sure, v2 sent.
> (checkpatch didn't moan at me with or without).

Thanks.  You'd need to apply the patch and re-run checkpatch.pl with the
-f option.  It's not something that's obvious.

regards,
dan carpenter


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ