linux-kernel - Re: [PATCH] x86/cpu/intel: Drop stray FAM6 check with new Intel CPU model defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ef9d8ad-9236-4254-b819-50832cd05cd9@intel.com>
Date: Wed, 29 May 2024 11:39:36 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Andrew Cooper <andrew.cooper3@...rix.com>,
 LKML <linux-kernel@...r.kernel.org>
Cc: Tony Luck <tony.luck@...el.com>, Dave Hansen
 <dave.hansen@...ux.intel.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
 Ashok Raj <ashok.raj@...el.com>,
 Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH] x86/cpu/intel: Drop stray FAM6 check with new Intel CPU
 model defines

On 5/29/24 11:36, Andrew Cooper wrote:
> The outer if () should have been dropped when switching to c->x86_vfm.

FWIW, we are going to need to do a pass over all of arch/x86 looking for
these.  I suspect many of the 'if (c->x86 == ...) ' checks can go away
like this one.

Thanks for finding this one, though!