linux-kernel - RE: [PATCH] x86/cpu/intel: Drop stray FAM6 check with new Intel CPU model defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB608327E76C4C90EAA3452D76FCF22@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Wed, 29 May 2024 18:59:27 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Hansen, Dave" <dave.hansen@...el.com>, "andrew.cooper3@...rix.com"
	<andrew.cooper3@...rix.com>, LKML <linux-kernel@...r.kernel.org>
CC: Dave Hansen <dave.hansen@...ux.intel.com>, Thomas Gleixner
	<tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
	<bp@...en8.de>, "x86@...nel.org" <x86@...nel.org>, "H. Peter Anvin"
	<hpa@...or.com>, "Raj, Ashok" <ashok.raj@...el.com>, "Schofield, Alison"
	<alison.schofield@...el.com>
Subject: RE: [PATCH] x86/cpu/intel: Drop stray FAM6 check with new Intel CPU
 model defines

>> The outer if () should have been dropped when switching to c->x86_vfm.
>
> FWIW, we are going to need to do a pass over all of arch/x86 looking for
> these.  I suspect many of the 'if (c->x86 == ...) ' checks can go away
> like this one.
>
> Thanks for finding this one, though!

Yup.

Acked-by: Tony Luck <tony.luck@...el.com>