linux-kernel - Re: [PATCH V3 7/8] clk: qcom: Add GPUCC driver support for SM4450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63d35ddacc113598f1822486b882552a.sboyd@kernel.org>
Date: Wed, 29 May 2024 12:48:14 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Ajit Pandey <quic_ajipan@...cinc.com>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Michael Turquette <mturquette@...libre.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, Vinod Koul <vkoul@...nel.org>, Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Taniya Das <quic_tdas@...cinc.com>, Jagadeesh Kona <quic_jkona@...cinc.com>, Imran Shaik <quic_imrashai@...cinc.com>, Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
Subject: Re: [PATCH V3 7/8] clk: qcom: Add GPUCC driver support for SM4450

Quoting Dmitry Baryshkov (2024-05-28 06:23:27)
> On Tue, May 28, 2024 at 05:12:53PM +0530, Ajit Pandey wrote:
> > Add Graphics Clock Controller (GPUCC) support for SM4450 platform.
> > 
> > Signed-off-by: Ajit Pandey <quic_ajipan@...cinc.com>
> > ---
> >  drivers/clk/qcom/Kconfig        |   9 +
> >  drivers/clk/qcom/Makefile       |   1 +
> >  drivers/clk/qcom/gpucc-sm4450.c | 805 ++++++++++++++++++++++++++++++++
> >  3 files changed, 815 insertions(+)
> >  create mode 100644 drivers/clk/qcom/gpucc-sm4450.c
> 
> [trimmed]
> 
> > +
> > +     /* Keep some clocks always enabled */
> > +     qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */
> > +     qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */
> > +     qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */
> 
> I pinged Stephen regarding these clocks. LGTM otherwise.
> 

Looks OK to me. I assume that these clks don't get turned off when the
GPU power domain is turned off. If that's the case then presumably we
would need to turn these on and off during power transitions.