linux-kernel - Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets (all, clean)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20ebb3a6-cdbb-4ffc-9ba2-c9eaa4d6ec74@nvidia.com>
Date: Thu, 30 May 2024 12:13:16 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Shuah Khan <shuah@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>, Darren Hart <dvhart@...radead.org>,
 Davidlohr Bueso <dave@...olabs.net>, Edward Liaw <edliaw@...gle.com>,
 André Almeida <andrealmeid@...lia.com>,
 "Nysal Jan K . A" <nysal@...ux.ibm.com>, Mark Brown <broonie@...nel.org>,
 Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets
 (all, clean)

On 5/30/24 12:03 PM, Shuah Khan wrote:
> On 5/28/24 20:29, John Hubbard wrote:
>> The .PHONY targets "all" and "clean"  are both defined in the file that
>> is included in the very next line: ../lib.mk.
>>
> 
> What problems are you seeing without this patch?

Code duplication. It's a sin. :)

> If I recall correctly, futex needs these defined.

And so they are defined, in the very next line:

     include ../lib.mk

..which has this:

PHONY: run_tests all clean install emit_tests gen_mods_dir clean_mods_dir

> 
> Please provide information on why this change is
> needed.

This patch is a valid cleanup, and doesn't introduce any problems
that I'm aware of. If there *are* problems that show up, those would
be deeper bugs, and I'll be happy to look into them and post solutions
if it comes up.

We don't just let latent bugs rest in peace. We fix them.

thanks,
-- 
John Hubbard
NVIDIA

> 
>> Reviewed-by: Davidlohr Bueso <dave@...olabs.net>
>> Signed-off-by: John Hubbard <jhubbard@...dia.com>
>> ---
>>   tools/testing/selftests/futex/Makefile | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/futex/Makefile 
>> b/tools/testing/selftests/futex/Makefile
>> index 11e157d7533b..78ab2cd111f6 100644
>> --- a/tools/testing/selftests/futex/Makefile
>> +++ b/tools/testing/selftests/futex/Makefile
>> @@ -3,8 +3,6 @@ SUBDIRS := functional
>>   TEST_PROGS := run.sh
>> -.PHONY: all clean
>> -
>>   include ../lib.mk
>>   all:
> 
> thanks,
> -- Shuah