linux-kernel - Re: [PATCH v2 2/3] selftests/futex: don't pass a const char* to asprintf(3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0a1ca78-f94e-4f02-a5e0-ef9d610fac07@nvidia.com>
Date: Thu, 30 May 2024 12:16:03 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Shuah Khan <shuah@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>, Darren Hart <dvhart@...radead.org>,
 Davidlohr Bueso <dave@...olabs.net>, Edward Liaw <edliaw@...gle.com>,
 André Almeida <andrealmeid@...lia.com>,
 "Nysal Jan K . A" <nysal@...ux.ibm.com>, Mark Brown <broonie@...nel.org>,
 Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH v2 2/3] selftests/futex: don't pass a const char* to
 asprintf(3)

On 5/30/24 12:04 PM, Shuah Khan wrote:
> On 5/28/24 20:29, John Hubbard wrote:
>> When building with clang, via:
>>
>>      make LLVM=1 -C tools/testing/selftests
>>
>> ...clang issues a warning, because test_name is passed into asprintf(3),
>> which then changes it.
> 
> Please include the warning in the commit log.

Ah, OK, the warning is:

futex_requeue_pi.c:403:17: warning: passing 'const char **' to parameter
of type 'char **' discards qualifiers in nested pointer types
[-Wincompatible-pointer-types-discards-qualifiers]

Please let me know if you'd prefer a v3, or if you'd rather fix it
up, whatever seems easiest for you.

thanks,
-- 
John Hubbard
NVIDIA