[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3db9068e-9f95-4ad9-86fa-e24b06da8828@linuxfoundation.org>
Date: Thu, 30 May 2024 15:12:56 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: John Hubbard <jhubbard@...dia.com>, Shuah Khan <shuah@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>, Darren Hart <dvhart@...radead.org>,
Davidlohr Bueso <dave@...olabs.net>, Edward Liaw <edliaw@...gle.com>,
André Almeida <andrealmeid@...lia.com>,
"Nysal Jan K . A" <nysal@...ux.ibm.com>, Mark Brown <broonie@...nel.org>,
Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] selftests/futex: don't redefine .PHONY targets
(all, clean)
On 5/30/24 13:13, John Hubbard wrote:
> On 5/30/24 12:03 PM, Shuah Khan wrote:
>> On 5/28/24 20:29, John Hubbard wrote:
>>> The .PHONY targets "all" and "clean" are both defined in the file that
>>> is included in the very next line: ../lib.mk.
>>>
>>
>> What problems are you seeing without this patch?
>
> Code duplication. It's a sin. :)
Please mention that you are removing duplicate code.
futex Makefile overrides CLEAN - just making sure it
does the cleanup correctly.
thanks,
-- Shuah
Powered by blists - more mailing lists