[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b245cd0a-8a87-4169-b0de-e4f6ce6984c6@linuxfoundation.org>
Date: Thu, 30 May 2024 15:13:40 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: John Hubbard <jhubbard@...dia.com>, Shuah Khan <shuah@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>, Darren Hart <dvhart@...radead.org>,
Davidlohr Bueso <dave@...olabs.net>, Edward Liaw <edliaw@...gle.com>,
André Almeida <andrealmeid@...lia.com>,
"Nysal Jan K . A" <nysal@...ux.ibm.com>, Mark Brown <broonie@...nel.org>,
Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 2/3] selftests/futex: don't pass a const char* to
asprintf(3)
On 5/30/24 13:16, John Hubbard wrote:
> On 5/30/24 12:04 PM, Shuah Khan wrote:
>> On 5/28/24 20:29, John Hubbard wrote:
>>> When building with clang, via:
>>>
>>> make LLVM=1 -C tools/testing/selftests
>>>
>>> ...clang issues a warning, because test_name is passed into asprintf(3),
>>> which then changes it.
>>
>> Please include the warning in the commit log.
>
> Ah, OK, the warning is:
>
> futex_requeue_pi.c:403:17: warning: passing 'const char **' to parameter
> of type 'char **' discards qualifiers in nested pointer types
> [-Wincompatible-pointer-types-discards-qualifiers]
>
>
> Please let me know if you'd prefer a v3, or if you'd rather fix it
> up, whatever seems easiest for you.
>
Yes please send me v3.
thanks,
-- Shuah
Powered by blists - more mailing lists