[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZljSJJtI-ADTUoc7@smile.fi.intel.com>
Date: Thu, 30 May 2024 22:23:16 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Devarsh Thakkar <devarsht@...com>
Cc: mchehab@...nel.org, hverkuil-cisco@...all.nl,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
benjamin.gaignard@...labora.com, sebastian.fricke@...labora.com,
akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
adobriyan@...il.com, jani.nikula@...el.com, p.zabel@...gutronix.de,
airlied@...il.com, daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
laurent.pinchart@...asonboard.com, praneeth@...com, nm@...com,
vigneshr@...com, a-bhatia1@...com, j-luthra@...com, b-brnich@...com,
detheridge@...com, p-mantena@...com, vijayp@...com,
andrzej.p@...labora.com, nicolas@...fresne.ca, davidgow@...gle.com,
dlatypov@...gle.com
Subject: Re: [PATCH v10 08/11] lib: add basic KUnit test for lib/math
On Thu, May 30, 2024 at 10:48:10PM +0530, Devarsh Thakkar wrote:
> From: Daniel Latypov <dlatypov@...gle.com>
>
> Add basic test coverage for files that don't require any config options:
> * part of math.h (what seem to be the most commonly used macros)
> * gcd.c
> * lcm.c
> * int_sqrt.c
> * reciprocal_div.c
> (Ignored int_pow.c since it's a simple textbook algorithm.)
>
> These tests aren't particularly interesting, but they
> * provide short and simple examples of parameterized tests
> * provide a place to add tests for any new files in this dir
> * are written so adding new test cases to cover edge cases should be
> easy
> * looking at code coverage, we hit all the branches in the .c files
..
> +#include <kunit/test.h>
> +#include <linux/gcd.h>
> +#include <linux/lcm.h>
> +#include <linux/reciprocal_div.h>
Really, you ignored my comment a second (?) time? This is road to nowhere.
You need to update the inclusion bloc in accordance with IWYU principle.
I see a few headers are missing.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists