linux-kernel - Re: [net-next PATCH] octeontx2: Improve mailbox tracepoints for debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202405310351.9HtVnVJ5-lkp@intel.com>
Date: Fri, 31 May 2024 03:48:51 +0800
From: kernel test robot <lkp@...el.com>
To: Subbaraya Sundeep <sbhatta@...vell.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Subbaraya Sundeep <sbhatta@...vell.com>,
	Sunil Goutham <sgoutham@...vell.com>,
	Linu Cherian <lcherian@...vell.com>,
	Geetha sowjanya <gakula@...vell.com>,
	Jerin Jacob <jerinj@...vell.com>, hariprasad <hkelam@...vell.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [net-next PATCH] octeontx2: Improve mailbox tracepoints for
 debugging

Hi Subbaraya,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Subbaraya-Sundeep/octeontx2-Improve-mailbox-tracepoints-for-debugging/20240530-195537
base:   net-next/main
patch link:    https://lore.kernel.org/r/1717070038-18381-1-git-send-email-sbhatta%40marvell.com
patch subject: [net-next PATCH] octeontx2: Improve mailbox tracepoints for debugging
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240531/202405310351.9HtVnVJ5-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240531/202405310351.9HtVnVJ5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405310351.9HtVnVJ5-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/net/ethernet/marvell/octeontx2/af/mbox.c: In function '__otx2_mbox_reset':
>> drivers/net/ethernet/marvell/octeontx2/af/mbox.c:23:29: warning: unused variable 'msg' [-Wunused-variable]
      23 |         struct mbox_msghdr *msg;
         |                             ^~~
   drivers/net/ethernet/marvell/octeontx2/af/mbox.c: In function 'otx2_mbox_msg_send_data':
>> drivers/net/ethernet/marvell/octeontx2/af/mbox.c:254:9: error: 'msg' undeclared (first use in this function); did you mean 'ndmsg'?
     254 |         msg = (struct mbox_msghdr *)(hw_mbase + mbox->tx_start + msgs_offset);
         |         ^~~
         |         ndmsg
   drivers/net/ethernet/marvell/octeontx2/af/mbox.c:254:9: note: each undeclared identifier is reported only once for each function it appears in


vim +254 drivers/net/ethernet/marvell/octeontx2/af/mbox.c

   216	
   217	static void otx2_mbox_msg_send_data(struct otx2_mbox *mbox, int devid, u64 data)
   218	{
   219		struct otx2_mbox_dev *mdev = &mbox->dev[devid];
   220		struct mbox_hdr *tx_hdr, *rx_hdr;
   221		void *hw_mbase = mdev->hwbase;
   222		u64 intr_val;
   223	
   224		tx_hdr = hw_mbase + mbox->tx_start;
   225		rx_hdr = hw_mbase + mbox->rx_start;
   226	
   227		/* If bounce buffer is implemented copy mbox messages from
   228		 * bounce buffer to hw mbox memory.
   229		 */
   230		if (mdev->mbase != hw_mbase)
   231			memcpy(hw_mbase + mbox->tx_start + msgs_offset,
   232			       mdev->mbase + mbox->tx_start + msgs_offset,
   233			       mdev->msg_size);
   234	
   235		spin_lock(&mdev->mbox_lock);
   236	
   237		tx_hdr->msg_size = mdev->msg_size;
   238	
   239		/* Reset header for next messages */
   240		mdev->msg_size = 0;
   241		mdev->rsp_size = 0;
   242		mdev->msgs_acked = 0;
   243	
   244		/* Sync mbox data into memory */
   245		smp_wmb();
   246	
   247		/* num_msgs != 0 signals to the peer that the buffer has a number of
   248		 * messages.  So this should be written after writing all the messages
   249		 * to the shared memory.
   250		 */
   251		tx_hdr->num_msgs = mdev->num_msgs;
   252		rx_hdr->num_msgs = 0;
   253	
 > 254		msg = (struct mbox_msghdr *)(hw_mbase + mbox->tx_start + msgs_offset);
   255	
   256		trace_otx2_msg_send(mbox->pdev, tx_hdr->num_msgs, tx_hdr->msg_size,
   257				    msg->id, msg->pcifunc);
   258	
   259		spin_unlock(&mdev->mbox_lock);
   260	
   261		/* Check if interrupt pending */
   262		intr_val = readq((void __iomem *)mbox->reg_base +
   263			     (mbox->trigger | (devid << mbox->tr_shift)));
   264	
   265		intr_val |= data;
   266		/* The interrupt should be fired after num_msgs is written
   267		 * to the shared memory
   268		 */
   269		writeq(intr_val, (void __iomem *)mbox->reg_base +
   270		       (mbox->trigger | (devid << mbox->tr_shift)));
   271	}
   272	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki