linux-kernel - Re: [PATCH v2] riscv: prevent pt_regs corruption for secondary idle threads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 30 May 2024 21:10:30 +0000
From: patchwork-bot+linux-riscv@...nel.org
To: Sergey Matyukevich <geomatsi@...il.com>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
 anup@...infault.org, atishp@...osinc.com, palmer@...belt.com,
 paul.walmsley@...ive.com, aou@...s.berkeley.edu, samuel.holland@...ive.com,
 alexghiti@...osinc.com, conor.dooley@...rochip.com,
 sergey.matyukevich@...tacore.com
Subject: Re: [PATCH v2] riscv: prevent pt_regs corruption for secondary idle
 threads

Hello:

This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <palmer@...osinc.com>:

On Thu, 23 May 2024 11:43:23 +0300 you wrote:
> From: Sergey Matyukevich <sergey.matyukevich@...tacore.com>
> 
> Top of the kernel thread stack should be reserved for pt_regs. However
> this is not the case for the idle threads of the secondary boot harts.
> Their stacks overlap with their pt_regs, so both may get corrupted.
> 
> Similar issue has been fixed for the primary hart, see c7cdd96eca28
> ("riscv: prevent stack corruption by reserving task_pt_regs(p) early").
> However that fix was not propagated to the secondary harts. The problem
> has been noticed in some CPU hotplug tests with V enabled. The function
> smp_callin stored several registers on stack, corrupting top of pt_regs
> structure including status field. As a result, kernel attempted to save
> or restore inexistent V context.
> 
> [...]

Here is the summary with links:
  - [v2] riscv: prevent pt_regs corruption for secondary idle threads
    https://git.kernel.org/riscv/c/a638b0461b58

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html