linux-kernel - Re: [PATCH v2 07/20] pinctrl: renesas: Use scope based of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXqXVT3Y7N8pTb_68E23RkLGi=ySOSDkAWX4MOpP09Q4g@mail.gmail.com>
Date: Thu, 30 May 2024 11:21:17 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: "Peng Fan (OSS)" <peng.fan@....nxp.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, 
	Dvorkin Dmitry <dvorkin@...bo.com>, Wells Lu <wellslutw@...il.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Emil Renner Berthing <kernel@...il.dk>, Jianlong Huang <jianlong.huang@...rfivetech.com>, 
	Hal Feng <hal.feng@...rfivetech.com>, Orson Zhai <orsonzhai@...il.com>, 
	Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, 
	Viresh Kumar <vireshk@...nel.org>, Shiraz Hashim <shiraz.linux.kernel@...il.com>, soc@...nel.org, 
	Krzysztof Kozlowski <krzk@...nel.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, 
	Alim Akhtar <alim.akhtar@...sung.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Patrice Chotard <patrice.chotard@...s.st.com>, Heiko Stuebner <heiko@...ech.de>, 
	Damien Le Moal <dlemoal@...nel.org>, Ludovic Desroches <ludovic.desroches@...rochip.com>, 
	Nicolas Ferre <nicolas.ferre@...rochip.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>, 
	Dong Aisheng <aisheng.dong@....com>, Fabio Estevam <festevam@...il.com>, 
	Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Chester Lin <chester62515@...il.com>, 
	Matthias Brugger <mbrugger@...e.com>, Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>, 
	Sean Wang <sean.wang@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Andrew Jeffery <andrew@...econstruct.com.au>, 
	Joel Stanley <joel@....id.au>, Dan Carpenter <dan.carpenter@...aro.org>, 
	Tony Lindgren <tony@...mide.com>, Stephen Warren <swarren@...dotorg.org>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, 
	linux-stm32@...md-mailman.stormreply.com, linux-samsung-soc@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-riscv@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
	imx@...ts.linux.dev, linux-aspeed@...ts.ozlabs.org, openbmc@...ts.ozlabs.org, 
	Peng Fan <peng.fan@....com>
Subject: Re: [PATCH v2 07/20] pinctrl: renesas: Use scope based of_node_put() cleanups

Hi Andy,

On Thu, May 30, 2024 at 11:03 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> Mon, May 13, 2024 at 01:59:03PM +0200, Geert Uytterhoeven kirjoitti:
> > On Sat, May 4, 2024 at 3:14 PM Peng Fan (OSS) <peng.fan@....nxpcom> wrote:
> > You missed one trivial conversion, presumably because no error handling
> > and thus no of_node_put() is involved?
>
> Nothing is missed. The below is a redundant change.
>
> ...
>
> > -       for_each_child_of_node(np, child) {
> > +       for_each_child_of_node_scoped(np, child) {
> >                 if (of_property_count_u32_elems(child, RZN1_PINS_PROP) > 0)
> >                         count++;
> >         }
> >
> > If you prefer not to include this
>
> I prefer this not to be included as it will give a misleading signals to the
> use of the original API(s).

Thank you for reminding me to send this out as a separate patch :-)

https://lore.kernel.org/r/c0a28f466c42d5d59c7fadfa1fd05fd512d43b6f.1717060708.git.geert+renesas@glider.be

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds