lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5a2f7786-bb02-441a-a60e-a7a548a30a79@web.de>
Date: Thu, 30 May 2024 11:40:21 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Peng Fan <peng.fan@....com>, "soc@...nel.org" <soc@...nel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Andrew Jeffery <andrew@...econstruct.com.au>,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Chester Lin <chester62515@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Damien Le Moal <dlemoal@...nel.org>, Dan Carpenter
 <dan.carpenter@...aro.org>, Aisheng Dong <aisheng.dong@....com>,
 Dvorkin Dmitry <dvorkin@...bo.com>, Emil Renner Berthing <kernel@...il.dk>,
 Fabio Estevam <festevam@...il.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 "Ghennadi Procopciuc (OSS)" <ghennadi.procopciuc@....nxp.com>,
 Hal Feng <hal.feng@...rfivetech.com>, Heiko Stübner
 <heiko@...ech.de>, Jacky Bai <ping.bai@....com>,
 Jianlong Huang <jianlong.huang@...rfivetech.com>,
 Joel Stanley <joel@....id.au>, Jonathan Hunter <jonathanh@...dia.com>,
 Krzysztof Kozlowski <krzk@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Ludovic Desroches <ludovic.desroches@...rochip.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Matthias Brugger <mbrugger@...e.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>, Orson Zhai
 <orsonzhai@...il.com>, Patrice Chotard <patrice.chotard@...s.st.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Sean Wang <sean.wang@...nel.org>,
 Shawn Guo <shawnguo@...nel.org>,
 Shiraz Hashim <shiraz.linux.kernel@...il.com>,
 Stephen Warren <swarren@...dotorg.org>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Thierry Reding <thierry.reding@...il.com>, Tony Lindgren <tony@...mide.com>,
 Viresh Kumar <vireshk@...nel.org>, Wells Lu <wellslutw@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-stm32@...md-mailman.stormreply.com"
 <linux-stm32@...md-mailman.stormreply.com>,
 "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>,
 "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
 "linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>,
 "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
 "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>,
 "Peng Fan (OSS)" <peng.fan@....nxp.com>,
 Emil Renner Berthing <emil.renner.berthing@...onical.com>
Subject: Re: [v2 04/20] pinctrl: starfive: Use scope based of_node_put()
 cleanups

>> 1. Exception handling is repeated a few times also according to memory
>> allocation failures.
>>    How do you think about to use a corresponding label like "e_nomem"
>>    so that another bit of duplicate source code can be avoided?
>
> I have no plan to rework this series for non-accepted patches. If you have
> interest and time, feel free to take it.
>>
>> https://wiki.se/
>> i.cmu.edu%2Fconfluence%2Fdisplay%2Fc%2FMEM12-
>> C.%2BConsider%2Busing%2Ba%2Bgoto%2Bchain%2Bwhen%2Bleaving%2Ba%
>> 2Bfunction%2Bon%2Berror%2Bwhen%2Busing%2Band%2Breleasing%2Bresou
>> rces&data=05%7C02%7Cpeng.fan%40nxp.com%7C293bafdf40524fa4655b08
>> dc7e58f6b2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63852
>> 4167804502915%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
>> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata
>> =Kb5cz6sVxW1TNfQ8MM2F6YLIIztyjvW4wULEJLYKRM8%3D&reserved=0

I became curious how the change acceptance will evolve further
also according to such a code transformation possibility.


>> 2. Will development interests grow for the usage of a statement like
>> "guard(mutex)(&sfp->mutex);"?
>
> I have no plan on this.

Other contributors might get attracted by corresponding design adjustments.
https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanup.h#L124

See also:
Looking at guard usage (with SmPL)
https://lore.kernel.org/cocci/2dc6a1c7-79bf-42e3-95cc-599a1e154f57@web.de/
https://sympa.inria.fr/sympa/arc/cocci/2024-05/msg00090.html

Regards,
Markus

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ