linux-kernel - Re: arm-linux-gnueabihf-ld: kernel/rcu/update.o:update.c:(.text+0x1cc4): more undefined references to `__bad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7f61cc11-7afe-46ac-9f07-62e0b9ab429f@app.fastmail.com>
Date: Thu, 30 May 2024 15:27:58 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Russell King" <linux@...linux.org.uk>,
 "Naresh Kamboju" <naresh.kamboju@...aro.org>
Cc: "open list" <linux-kernel@...r.kernel.org>,
 "Linux ARM" <linux-arm-kernel@...ts.infradead.org>,
 lkft-triage@...ts.linaro.org,
 "Linux Regressions" <regressions@...ts.linux.dev>, rcu <rcu@...r.kernel.org>,
 "Dan Carpenter" <dan.carpenter@...aro.org>,
 "Paul E. McKenney" <paulmck@...nel.org>,
 "Joel Fernandes" <joel@...lfernandes.org>, eeraj.upadhyay@...nel.org,
 "John Ogness" <john.ogness@...utronix.de>
Subject: Re: arm-linux-gnueabihf-ld: kernel/rcu/update.o:update.c:(.text+0x1cc4): more
 undefined references to `__bad_cmpxchg' follow

On Thu, May 30, 2024, at 14:26, Russell King (Oracle) wrote:
> On Thu, May 30, 2024 at 05:50:52PM +0530, Naresh Kamboju wrote:
>> The arm builds failed on Linux next with gcc-13 and clang-18.
>> 
>> Config: arm imx_v6_v7_defconfig - failed
>> 
>> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
>> 
>> Build log:
>> -----
>> arm-linux-gnueabihf-ld: kernel/rcu/update.o: in function
>> `rcu_trc_cmpxchg_need_qs':
>> update.c:(.text+0x348): undefined reference to `__bad_cmpxchg'
>> arm-linux-gnueabihf-ld: kernel/rcu/update.o: in function
>> `rcu_read_unlock_trace_special':
>> update.c:(.text+0x41c): undefined reference to `__bad_cmpxchg'
>> arm-linux-gnueabihf-ld: kernel/rcu/update.o: in function
>> `trc_read_check_handler':
>> update.c:(.text+0x4b0): undefined reference to `__bad_cmpxchg'
>> arm-linux-gnueabihf-ld: kernel/rcu/update.o: in function `trc_inspect_reader':
>> update.c:(.text+0x1518): undefined reference to `__bad_cmpxchg'
>> arm-linux-gnueabihf-ld: update.c:(.text+0x1548): undefined reference
>> to `__bad_cmpxchg'
>> arm-linux-gnueabihf-ld: kernel/rcu/update.o:update.c:(.text+0x1cc4):
>> more undefined references to `__bad_cmpxchg' follow
>> make[3]: *** [/builds/linux/scripts/Makefile.vmlinux:34: vmlinux] Error 1
>
> You get a reference to __bad_cmpxchg() when someone uses cmpxchg() on
> a datatype that there are no CPU instructions to perform the atomic
> compare-and-exchange.
>
> As we support 8-bit, 16-bit and 32-bit, I would expect that we're now
> seeing cmpxchg() being used on 64-bit values, which are unsupportable
> on 32-bit Arm.

A 64-bit cmpxchg() would fail on most 32-bit architectures,
other than armv6k+ and i686+. Since this one fails on
an armv6 (non-6k) build, it's probably the added 8-bit
cmpxchg() that Paul talked about using for RCU, though I
don't see that in linux-next here.

I htink we need to use the emulated cmpxchg8() in
__cmpxchg() for this case, just like we do on other
architectures that only have word size atomics.

      Arnd