linux-kernel - Re: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173c371a-5669-432a-9826-ce799102f6c1@app.fastmail.com>
Date: Fri, 31 May 2024 18:29:28 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: 
 "srinivas.pandruvada@...ux.intel.com" <srinivas.pandruvada@...ux.intel.com>,
 "Lixu Zhang" <lixu.zhang@...el.com>, "Arnd Bergmann" <arnd@...nel.org>,
 "Jiri Kosina" <jikos@...nel.org>, "Benjamin Tissoires" <bentiss@...nel.org>
Cc: "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] HID: intel-ish-hid: fix endian-conversion

On Fri, May 31, 2024, at 05:49, srinivas pandruvada wrote:
> On Wed, 2024-05-29 at 15:18 +0200, Arnd Bergmann wrote:
>> On Wed, May 29, 2024, at 09:05, Zhang, Lixu wrote:
>> 
>> > > 
>> > > 	for (i = 0; i < fragment->fragment_cnt && offset <
>> > > ish_fw->size; i++) {
>> > You added a parameter fragment_count, but you didn't use it. Did
>> > you 
>> > intend to use it here?
>> > 
>> 
>> My mistake, that was again broken in my incorrect
>> rebase.
>> 
> Do you have updated patch? Lixu can try and make sure that the
> functionality is not broken by changes.
>

I've sent v2 now, hopefully addressing all the issues
of the first version. I've dropped the other patch now,
though I still think something is wrong there.

    Arnd