linux-kernel - Re: [PATCH] list: test: remove unused struct 'klist_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9091516-37ff-43d1-b515-ae8eb3f80e80@linuxfoundation.org>
Date: Fri, 31 May 2024 13:13:27 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: davidgow@...gle.com, linux-kselftest@...r.kernel.org,
 kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] list: test: remove unused struct 'klist_test_struct'

On 5/31/24 12:58, Dr. David Alan Gilbert wrote:
> * Muhammad Usama Anjum (usama.anjum@...labora.com) wrote:
>> On 5/31/24 8:18 PM, linux@...blig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>>>
>>> 'klist_test_struct' has been unused since the original
>>> commit 57b4f760f94d ("list: test: Test the klist structure").
>> Probably a fixes by tag would be needed here.
> 
> I'm generally avoiding fixes tags in this set of changes, since
>    a) They have no behavioural change at all.
>    b) Downstream and stable kernel people use fixes tags to indicate
>       stuff they should pick up if they have the original, and there's
>       no need for them to do that with this cleanup.
> 
> Dave

+1 on using careful use of Fixes tag only on real fixes for the
reasons mentioned above.

thanks,
-- Shuah