linux-kernel - Re: [PATCH] list: test: remove unused struct 'klist_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOSk2xPmgYPEoRwqWW0YJx8oU-Z2UOX=8iWtiod6FFposPQ@mail.gmail.com>
Date: Sat, 1 Jun 2024 10:07:43 +0800
From: David Gow <davidgow@...gle.com>
To: linux@...blig.org
Cc: linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] list: test: remove unused struct 'klist_test_struct'

On Fri, 31 May 2024 at 23:18, <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> 'klist_test_struct' has been unused since the original
> commit 57b4f760f94d ("list: test: Test the klist structure").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---

Nice catch, thanks! That's what I get for copy-patste, I guess! :-)

(I agree that this is better without the Fixes tag, too.)

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

>  lib/list-test.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/lib/list-test.c b/lib/list-test.c
> index 0cc27de9cec8..383ee0ad582e 100644
> --- a/lib/list-test.c
> +++ b/lib/list-test.c
> @@ -1201,12 +1201,6 @@ static struct kunit_suite hlist_test_module = {
>  };
>
>
> -struct klist_test_struct {
> -       int data;
> -       struct klist klist;
> -       struct klist_node klist_node;
> -};
> -
>  static int node_count;
>  static struct klist_node *last_node;
>
> --
> 2.45.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4014 bytes)