linux-kernel - Re: [PATCH v6 0/1] Add tas2781 driver for SPI.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 31 May 2024 06:10:44 +0000
From: "Xu, Baojun" <baojun.xu@...com>
To: "tiwai@...e.de" <tiwai@...e.de>
CC: "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz"
	<perex@...ex.cz>,
        "pierre-louis.bossart@...ux.intel.com"
	<pierre-louis.bossart@...ux.intel.com>,
        "Lu, Kevin" <kevin-lu@...com>,
        "Ding,
 Shenghao" <shenghao-ding@...com>,
        "Navada Kanyana, Mukund" <navada@...com>,
        "13916275206@....com" <13916275206@....com>,
        "Hampiholi, Vallabha"
	<v-hampiholi@...com>,
        "P O, Vijeth" <v-po@...com>,
        "Holalu Yogendra,
 Niranjan" <niranjan.hy@...com>,
        "alsa-devel@...a-project.org"
	<alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "liam.r.girdwood@...el.com"
	<liam.r.girdwood@...el.com>,
        "yung-chuan.liao@...ux.intel.com"
	<yung-chuan.liao@...ux.intel.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "soyer@....hu" <soyer@....hu>
Subject: Re: [PATCH v6 0/1] Add tas2781 driver for SPI.

Hi Pierre,

Do you know any different between windows and Ubuntu on SPI inialyze?
We are testing my patch on Laptop (HP-Varcolac, SSID:103C8B92, fly-out SPI & I2S cables), no any issue with wondows, but with Linux, second speaker has no sound, it's initialyze is totally same with first AMP, and relative registers can be dumped, no problem found.

Best Regards
Jim
________________________________________
From: Xu, Baojun
Sent: 29 May 2024 23:56
To: tiwai@...e.de
Cc: robh+dt@...nel.org; andriy.shevchenko@...ux.intel.com; lgirdwood@...il.com; perex@...ex.cz; pierre-louis.bossart@...ux.intel.com; Lu, Kevin; Ding, Shenghao; Navada Kanyana, Mukund; 13916275206@....com; Hampiholi, Vallabha; P O, Vijeth; Holalu Yogendra, Niranjan; alsa-devel@...a-project.org; linux-kernel@...r.kernel.org; liam.r.girdwood@...el.com; yung-chuan.liao@...ux.intel.com; Xu, Baojun; broonie@...nel.org; soyer@....hu
Subject: [PATCH v6 0/1] Add tas2781 driver for SPI.

This patch was used to add TAS2781 devices on SPI support in sound/pci/hda.
It use ACPI node descript about parameters of TAS2781 on SPI, it like:
    Scope (_SB.PC00.SPI0)
    {
        Device (GSPK)
        {
            Name (_HID, "TXNW2781")  // _HID: Hardware ID
            Method (_CRS, 0, NotSerialized)
            {
                Name (RBUF, ResourceTemplate ()
                {
                    SpiSerialBusV2 (...)
                    SpiSerialBusV2 (...)
                }
            }
        }
    }

And in platform/x86/serial-multi-instantiate.c, those spi devices will be
added into system as a single SPI device, so TAS2781 SPI driver will
probe twice for every single SPI device. And driver will also parser
mono DSP firmware binary and RCA binary for itself.

Signed-off-by: Baojun Xu <baojun.xu@...com>

Baojun Xu (1):
  ALSA: hda/tas2781: Add tas2781 hda driver based on SPI

 drivers/acpi/scan.c                           |    1 +
 .../platform/x86/serial-multi-instantiate.c   |   12 +
 sound/pci/hda/Kconfig                         |   14 +
 sound/pci/hda/Makefile                        |    2 +
 sound/pci/hda/patch_realtek.c                 |   13 +
 sound/pci/hda/tas2781-spi.h                   |  148 ++
 sound/pci/hda/tas2781_hda_spi.c               | 1266 ++++++++++
 sound/pci/hda/tas2781_spi_fwlib.c             | 2101 +++++++++++++++++
 8 files changed, 3557 insertions(+)
 create mode 100644 sound/pci/hda/tas2781-spi.h
 create mode 100644 sound/pci/hda/tas2781_hda_spi.c
 create mode 100644 sound/pci/hda/tas2781_spi_fwlib.c

--
2.40.1