linux-kernel - Re: [PATCH] auxdisplay: linedisp: Support configuring the boot message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXg1GCAqYPy++4UjFN6QsCnfikZdvsz5=2G4j13E3DUjQ@mail.gmail.com>
Date: Fri, 31 May 2024 10:22:02 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Chris Packham <chris.packham@...iedtelesis.co.nz>, andy@...nel.org, tzimmermann@...e.de, 
	ojeda@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] auxdisplay: linedisp: Support configuring the boot message

Hi Andy,

On Fri, May 31, 2024 at 10:16 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Fri, May 31, 2024 at 10:45 AM Geert Uytterhoeven
> <geert@...ux-m68k.org> wrote:
> > On Fri, May 31, 2024 at 7:28 AM Chris Packham
> > <chris.packham@...iedtelesis.co.nz> wrote:
> > > Like we do for charlcd, allow the configuration of the initial message
> > > on line-display devices.
>
> ...
>
> > > +#ifndef CONFIG_PANEL_BOOT_MESSAGE
> > >  #include <generated/utsrelease.h>
> > > +#endif
> >
> > The #ifndef/#endif is not really needed.
>
> It's needed to avoid unnecessary build of the module (in case of m).

OK.

> > As I see no real deficiencies:
> > Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
> I believe you agree with leaving ifdeffery above.

Thanks, I agree to agree ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds