[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3b3beca0-80f7-4a20-93d0-01af89fcf508@kernel.org>
Date: Fri, 31 May 2024 11:38:09 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>,
Chanwoo Choi <cw00.choi@...sung.com>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Alim Akhtar <alim.akhtar@...sung.com>, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
~postmarketos/upstreaming@...ts.sr.ht, Henrik Grimler <henrik@...mler.se>,
Wolfgang Wiedmeyer <wolfgit@...dmeyer.de>,
Denis 'GNUtoo' Carikli <GNUtoo@...erdimension.org>
Subject: Re: [PATCH RFC 05/11] power: supply: max77693: Expose
INPUT_CURRENT_LIMIT and CURRENT_MAX
On 30/05/2024 10:55, Artur Weber wrote:
> There are two charger current limit registers:
>
> - Fast charge current limit (which controls current going from the
> charger to the battery);
> - CHGIN input current limit (which controls current going into the
> charger through the cable, and is managed by the CHARGER regulator).
>
> + case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
> + ret = max77693_get_input_current_limit(chg, &val->intval);
> + break;
> + case POWER_SUPPLY_PROP_CURRENT_MAX:
> + ret = max77693_get_fast_charge_current(regmap, &val->intval);
> + break;
> case POWER_SUPPLY_PROP_MODEL_NAME:
> val->strval = max77693_charger_model;
> break;
> @@ -680,6 +727,11 @@ static int max77693_charger_probe(struct platform_device *pdev)
> chg->dev = &pdev->dev;
> chg->max77693 = max77693;
>
> + chg->regu = devm_regulator_get(chg->dev, "CHARGER");
> + if (IS_ERR(chg->regu))
> + return dev_err_probe(&pdev->dev, PTR_ERR(chg->regu),
> + "failed to get charger regulator\n");\
This breaks users... and where is the binding?
Best regards,
Krzysztof
Powered by blists - more mailing lists