linux-kernel - Re: [PATCH v1 net-next 3/4] vmxnet3: add command to allow disabling of offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240530180520.74899d37@kernel.org>
Date: Thu, 30 May 2024 18:05:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ronak Doshi <ronak.doshi@...adcom.com>
Cc: <netdev@...r.kernel.org>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 net-next 3/4] vmxnet3: add command to allow disabling
 of offloads

On Tue, 28 May 2024 16:39:05 -0700 Ronak Doshi wrote:
> @@ -270,6 +270,14 @@ netdev_features_t vmxnet3_fix_features(struct net_device *netdev,
>  	if (!(features & NETIF_F_RXCSUM))
>  		features &= ~NETIF_F_LRO;
>  
> +	if ((features & NETIF_F_LRO) &&
> +	    (adapter->disabledOffloads & VMXNET3_OFFLOAD_LRO))
> +		features &= ~NETIF_F_LRO;
> +
> +	if ((features & (NETIF_F_TSO | NETIF_F_TSO6)) &&
> +	    (adapter->disabledOffloads & VMXNET3_OFFLOAD_TSO))
> +		features &= ~(NETIF_F_TSO | NETIF_F_TSO6);

Why do you clear them in fix_features?
They are not declared as supported how can they get enabled?
-- 
pw-bot: cr