linux-kernel - Re: [PATCH v1 net-next 2/4] vmxnet3: add latency measurement support in vmxnet3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240530180955.4e542935@kernel.org>
Date: Thu, 30 May 2024 18:09:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ronak Doshi <ronak.doshi@...adcom.com>
Cc: <netdev@...r.kernel.org>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 net-next 2/4] vmxnet3: add latency measurement
 support in vmxnet3

On Tue, 28 May 2024 16:39:04 -0700 Ronak Doshi wrote:
> This patch enhances vmxnet3 to support latency measurement.
> This support will help to track the latency in packet processing
> between guest virtual nic driver and host. For this purpose, we
> introduce a new timestamp ring in vmxnet3 which will be per Tx/Rx
> queue. This ring will be used to carry timestamp of the packets
> which will be used to calculate the latency.

How does the user access this functionality?
Please provide more info in the commit msg.

> +	if (VMXNET3_VERSION_GE_9(adapter)) {
> +		adapter->latencyConf = &adapter->tqd_start->tsConf.latencyConf;
> +	}

unnecessary parenthesis, please fix all such cases in this set