linux-kernel - Re: [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <324610c0-b9e7-4807-92dd-c887c135ca12@habana.ai>
Date: Fri, 31 May 2024 12:22:14 +0000
From: Tomer Tayar <ttayar@...ana.ai>
To: Thorsten Blum <thorsten.blum@...lux.com>,
        Oded Gabbay
	<ogabbay@...nel.org>, Ofir Bitton <obitton@...ana.ai>,
        Farah Kassabri
	<fkassabri@...ana.ai>,
        Dani Liberman <dliberman@...ana.ai>,
        Dafna Hirschfeld
	<dhirschfeld@...ana.ai>,
        Koby Elbaz <kelbaz@...ana.ai>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory
 allocated with kvcalloc()

On 31/05/2024 13:46, Thorsten Blum wrote:
> Use kvfree() to fix the following Coccinelle/coccicheck warning reported
> by kfree_mismatch.cocci:
>
> 	WARNING kvmalloc is used to allocate this memory at line 10398
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>

Reviewed-by: Tomer Tayar <ttayar@...ana.ai>

> ---
>   drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c
> index fa1c4feb9f89..8024047962ec 100644
> --- a/drivers/accel/habanalabs/gaudi2/gaudi2.c
> +++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c
> @@ -10489,7 +10489,7 @@ static int gaudi2_memset_device_memory(struct hl_device *hdev, u64 addr, u64 siz
>   				(u64 *)(lin_dma_pkts_arr), DEBUGFS_WRITE64);
>   	WREG32(sob_addr, 0);
>   
> -	kfree(lin_dma_pkts_arr);
> +	kvfree(lin_dma_pkts_arr);
>   
>   	return rc;
>   }