linux-kernel - Re: [QUESTION] mm: Redundant const parameter?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f02792b7-ddf4-48c4-954d-aba20bebee61@arm.com>
Date: Fri, 31 May 2024 17:54:38 +0530
From: Dev Jain <dev.jain@....com>
To: Matthew Wilcox <willy@...radead.org>
Cc: zhouchengming@...edance.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Anshuman.Khandual@....com
Subject: Re: [QUESTION] mm: Redundant const parameter?

I was just about to hit git send-email for a patch-series of 2, I 
noticed your reply :)

On 5/31/24 17:47, Matthew Wilcox wrote:
> On Fri, May 31, 2024 at 04:42:59PM +0530, Dev Jain wrote:
>> Hi Chengming,
>>
>> In mm/slub.c, you had defined slab_test_node_partial() to take a const
>> parameter.
>>
>> Is there any point of taking in a const, when you are anyways typecasting it
>> to
>>
>> a (struct folio *) from (const struct folio *) ? In fact, at the place where
>> you call
>>
>> slab_test_node_partial(), the struct slab *slab is not const.
> I have a patch to fix this; hang on a second ...