linux-kernel - Re: [QUESTION] mm: Redundant const parameter?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zlm_vlhYa91fA1wu@casper.infradead.org>
Date: Fri, 31 May 2024 13:17:03 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Dev Jain <dev.jain@....com>
Cc: zhouchengming@...edance.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Anshuman.Khandual@....com
Subject: Re: [QUESTION] mm: Redundant const parameter?

On Fri, May 31, 2024 at 04:42:59PM +0530, Dev Jain wrote:
> Hi Chengming,
> 
> In mm/slub.c, you had defined slab_test_node_partial() to take a const
> parameter.
> 
> Is there any point of taking in a const, when you are anyways typecasting it
> to
> 
> a (struct folio *) from (const struct folio *) ? In fact, at the place where
> you call
> 
> slab_test_node_partial(), the struct slab *slab is not const.

I have a patch to fix this; hang on a second ...